Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lua): re-implement luaSetSerialBaudrate #4501

Merged
merged 1 commit into from
Jan 3, 2024
Merged

fix(lua): re-implement luaSetSerialBaudrate #4501

merged 1 commit into from
Jan 3, 2024

Conversation

raphaelcoeffic
Copy link
Member

Fixes #4466

Summary of changes:

  • added serialGetBaudrate, serialSetBaudrate and serialGetModePort,
  • re-implement luaSetSerialBaudrate.

@pfeerick pfeerick added bug/regression ↩️ A new version of EdgeTX broke something lua-api Lua API related labels Jan 1, 2024
@pfeerick pfeerick added this to the 2.10 milestone Jan 1, 2024
@pfeerick
Copy link
Member

pfeerick commented Jan 3, 2024 •
edited
Loading

This indeed fixes the luaSetSerialBaudrate issue... SerialWrite is correctly writing at different baud rates after a setSerialBaudrate() call. I don't have anything setup atm to check SerialRead though. It appears though for SerialWrite that 115200 is the default baud rate if one is not set.

@pfeerick pfeerick merged commit 317766d into main Jan 3, 2024
39 checks passed
@pfeerick pfeerick deleted the fix-4466 branch January 3, 2024 03:29
pfeerick pushed a commit that referenced this pull request Jan 4, 2024
@raphaelcoeffic @pfeerick
fix(lua): Re-implement luaSetSerialBaudrate (#4501)
667ae5e
@pfeerick pfeerick mentioned this pull request Feb 6, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug/regression ↩️ A new version of EdgeTX broke something lua-api Lua API related
Projects
None yet
Milestone
2.10
Development

Successfully merging this pull request may close these issues.

LUA serialRead() function doesn't work either setSerialBaudrate()
2 participants
@raphaelcoeffic @pfeerick